Skip to content

Remove local file preference storage and cleanup Invoke-WinutilThemeChange#4617

Merged
ChrisTitusTech merged 18 commits into
ChrisTitusTech:mainfrom
GabiNun2:remove-local-preferences
Jul 2, 2026
Merged

Remove local file preference storage and cleanup Invoke-WinutilThemeChange#4617
ChrisTitusTech merged 18 commits into
ChrisTitusTech:mainfrom
GabiNun2:remove-local-preferences

Conversation

@GabiNun2

@GabiNun2 GabiNun2 commented Jun 3, 2026 •
edited by ChrisTitusTech
Loading

Copy link
Copy Markdown
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • UI/UX improvement

Description

i think it's kind a niche to save choco/winget checkboxs because most people just stay with winget and i don't think a powershell script should leave files on your computer other than logs

@GabiNun2 GabiNun2 requested a review from ChrisTitusTech as a code owner June 3, 2026 14:20
@GabiNun2 GabiNun2 changed the title Remove local file preference storage Remove local file preference storage and cleanup Invoke-WinutilThemeChange Jun 3, 2026
@ChrisTitusTech ChatGPT Codex Connector

ChrisTitusTech commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Pushed conflict-resolution commit b5b65b1 to GabiNun2:remove-local-preferences.

Changes made:

  • Removed the file-backed preference flow by deleting functions/private/Set-Preferences.ps1 and its call sites.
  • Kept theme and package-manager choices in memory only, defaulting startup to Auto theme and Winget.
  • Preserved the current Invoke-WinutilThemeChange theme-application logic, removing only the Set-Preferences -save side effect. I did not keep the simplified rewrite because it dropped the actual selected-theme application path.
  • Updated pester/preferences-theme.Tests.ps1 to cover the remaining theme behavior and assert that preferences.ini is not written.
  • Left generated winutil.ps1 uncommitted/ignored.

Verification:

  • Import-Module Pester -RequiredVersion 5.8.0 -Force; Invoke-Pester -Path 'pester/preferences-theme.Tests.ps1' -Output Detailed passed: 3/3.
  • ./Compile.ps1 completed successfully.

@github-actions github-actions Bot added the ui update UI/UX improvements label Jul 2, 2026
@ChrisTitusTech ChrisTitusTech merged commit de6652a into ChrisTitusTech:main Jul 2, 2026
4 checks passed
@GabiNun2 GabiNun2 deleted the remove-local-preferences branch July 2, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees

No one assigned

Labels

ui update UI/UX improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GabiNun2 @ChrisTitusTech